Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script for typescript-language-server #1064

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 1, 2024

References

Looking into using typescript-language-server and following the docs to install it, it looks like jupyter_lsp was not able to find the language server:

image

Updating the script seems to be fixing it:

image

Code changes

Update the script for typescript-language-server.

User-facing changes

Users can install and use typescript-language-server with JupyterLab LSP.

Backwards-incompatible changes

This supports the latest version of typescript-language-server, but might break previous versions when the file was still cli.js?

Chores

  • linted
  • tested
  • documented
  • changelog entry

Copy link

github-actions bot commented Mar 1, 2024

Binder 👈 Launch a binder notebook on branch jtpio/jupyterlab-lsp/typescript-script

@krassowski
Copy link
Member

The test failures are relevant. It looks the location of the binary entry point has changed last year and we are pinning to an old version. I think we should bump the version, but also consider using the bin field from package.json.

@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2024

I think we should bump the version

Done in f014c9e 👍

but also consider using the bin field from package.json.

That makes sense, although there might be several scripts available, and the name might not match the name of the module itself? I guess this would apply to other specs derived from NodeModuleSpec, so maybe something to track in a separate issue?

@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2024

maybe something to track in a separate issue?

Opened #1066

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio and thanks for opening the issue!

@krassowski krassowski merged commit 11e1db4 into jupyter-lsp:main Mar 4, 2024
23 checks passed
@jtpio jtpio deleted the typescript-script branch March 4, 2024 15:41
@krassowski
Copy link
Member

@jtpio this is available in jupyter-lsp 2.2.4 - thanks again!

@jtpio
Copy link
Member Author

jtpio commented Mar 5, 2024

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants