Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically show and dismiss notifications #965

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

krassowski
Copy link
Member

References

Follow up to #949 - use transient notifications to avoid spamming the notification centre.

Code changes

  • adds autoClose option where needed replacing manual Notificaiton.dismiss calls

User-facing changes

Before After
before after

Backwards-incompatible changes

None

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/better-notifications

@krassowski krassowski merged commit eacfc19 into jupyter-lsp:main Aug 29, 2023
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant