Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore diagnostics panel on refreshing #967

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Restore diagnostics panel on refreshing #967

merged 1 commit into from
Aug 29, 2023

Conversation

krassowski
Copy link
Member

References

Fixes #167

Code changes

  • adds optional dependency on ILayoutRestorer,
  • adds tracker to facilitate restoration

User-facing changes

Diagnostics panel is preserved when reloading JupyterLab

Backwards-incompatible changes

None

@krassowski krassowski added the enhancement New feature or request label Aug 27, 2023
@krassowski krassowski added this to the 5.0 milestone Aug 27, 2023
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/restore-panel

@krassowski krassowski merged commit 3bf1c07 into jupyter-lsp:main Aug 29, 2023
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Make the Diagnostics Panel remember its position
1 participant
@krassowski