Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: JupyterLab with Kernel Provider on Kubernetes #300

Closed

Conversation

echarles
Copy link
Member

@echarles echarles commented Sep 3, 2020

Adds an example for JupyterLab with Kernel Provider on Kubernetes

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I've given some initial comments. Lots of changes will be likely in the gateway-experiments repos.

examples/jlab-kernel-provider-k8s/Dockerfile Outdated Show resolved Hide resolved
examples/jlab-kernel-provider-k8s/Dockerfile Show resolved Hide resolved
examples/jlab-kernel-provider-k8s/Dockerfile Outdated Show resolved Hide resolved
examples/jlab-kernel-provider-k8s/jlab.yaml Outdated Show resolved Hide resolved
examples/jlab-kernel-provider-k8s/jlab.yaml Show resolved Hide resolved
examples/jlab-kernel-provider-k8s/jlab.yaml Show resolved Hide resolved
@echarles
Copy link
Member Author

echarles commented Sep 4, 2020

@kevin-bates Thx a lot for your comments and the debugging session we have done yesterday.

I have invested more time today to debug the launch and the creation steps of the remote kernel. Something I have realized is that the python source changes are not picked up after the first invocation of those sources (even removing the pyc files). I have finally been able to have the pod remaining. Tried the grace-period... but finally simply remove the code responsible to remove the resource. The pod was working fine... so I have a second look at gateway-experiments/remote_kernel_provider@fc0fdea and it turns out that this was the cause.

Current Pr works fine

Screenshot 2020-09-04 at 12 16 48

Let's further discuss the next steps at the weekly meeting.

I may add spark to this, but this is ready for review.

@echarles echarles marked this pull request as ready for review September 4, 2020 10:32
@echarles
Copy link
Member Author

Closing as jupyter/enhancement-proposals#45 has not been merged.

@echarles echarles closed this Oct 11, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants