Fix `Check Release / check_release` CI job #102

echarles · 2022-05-20T11:02:47Z

This PR aims to fix the releaser CI job

blink1073 · 2022-05-20T14:22:29Z

Here's the config we used in Notebook 6.4

echarles · 2022-05-20T15:22:42Z

Thx @blink1073. I have added a few more commits on #102. The check_release job now goes further and stops now with the following errors (details on https://github.com/jupyter/nbclassic/runs/6526987103?check_suite_focus=true#step:9:3077)

Creating tar archive
removing 'nbclassic-0.3.8' (and everything under it)
ERROR Source /tmp/build-via-sdist-wad9hepq/nbclassic-0.3.8 does not appear to be a Python project: no pyproject.toml or setup.py
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.12/x64/bin/jupyter-releaser", line 8, in <module>
    sys.exit(main())

blink1073 · 2022-05-20T21:50:00Z

python -m build is using the sdist to create the wheel. I think you need to include setup.py, setup.cfg and pyproject.toml in MANIFEST.in.

echarles · 2022-05-21T08:52:08Z

I am still missing something in the process. Hacked rules in MANIFEST.in and the returned error is now

missing from sdist:
  docs-translations/hi-IN/README.md
  docs-translations/hi-IN/resources/Notebook_Editor.GIF
  docs-translations/hi-IN/resources/dashboard.GIF
  docs-translations/hi-IN/resources/edit_mode.GIF
  docs-translations/hi-IN/resources/file_editor.GIF
  docs-translations/hi-IN/resources/running_code_med.png
  docs-translations/ja-JP/README.md
  docs-translations/ja-JP/resources/Notebook_Editor.GIF
  docs-translations/ja-JP/resources/dashboard.GIF
  docs-translations/ja-JP/resources/edit_mode.GIF
  docs-translations/ja-JP/resources/file_editor.GIF
  docs-translations/ja-JP/resources/running_code_med.png
  docs-translations/ko-KR/HowtoRun.md
  docs-translations/ko-KR/Installation.md
  docs-translations/ko-KR/README.md
  docs-translations/ko-KR/UIComponents.md
  docs-translations/ko-KR/resources/Notebook_Editor.GIF
  docs-translations/ko-KR/resources/dashboard.GIF
  docs-translations/ko-KR/resources/edit_mode.GIF
  docs-translations/ko-KR/resources/file_editor.GIF
  docs-translations/ko-KR/resources/running_code_med.png
  docs-translations/zh-CN/README.md
  docs-translations/zh-CN/resources/Notebook_Editor.GIF
  docs-translations/zh-CN/resources/dashboard.GIF
  docs-translations/zh-CN/resources/edit_mode.GIF
  docs-translations/zh-CN/resources/file_editor.GIF
  docs-translations/zh-CN/resources/running_code_med.png
  git-hooks/README.md
  git-hooks/install-hooks.sh
  git-hooks/post-checkout
  git-hooks/post-merge
listing source files under version control: 425 files and directories
building an sdist: nbclassic-0.3.8.tar.gz: 1507 files and directories

blink1073 · 2022-05-21T10:54:00Z

MANIFEST.in

+graft tools
+graft nbclassic/tests
+
+exclude git-hooks


These should be prune: https://packaging.python.org/en/latest/guides/using-manifest-in/#manifest-in-commands

echarles · 2022-05-22T07:54:26Z

The manifest.in file seems to be tuned now. On https://pipelines.actions.githubusercontent.com/serviceHosts/f8547054-8c5a-4a55-9535-e755a3b0bb79/_apis/pipelines/1/runs/885/signedlogcontent/2?urlExpires=2022-05-22T07%3A52%3A47.2463120Z&urlSigningMethod=HMACV1&urlSignature=Voi3BdwWf0YrcQj%2BGX8YiGAw%2FzLhH9kh2eXkGJcwnnU%3D the number of file/directories in the sdist and repo is not the same, which sound ok to me.

2022-05-22T07:51:31.5075162Z listing source files under version control: 394 files and directories
2022-05-22T07:51:31.5075416Z building an sdist: nbclassic-0.3.8.tar.gz: 30700 files and directories
```

It then fails with where I can see the root cause.

```
2022-05-22T07:51:31.5075902Z Traceback (most recent call last):
2022-05-22T07:51:31.5084267Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/bin/jupyter-releaser", line 8, in <module>
2022-05-22T07:51:31.5084434Z     sys.exit(main())
2022-05-22T07:51:31.5084921Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
2022-05-22T07:51:31.5085044Z     return self.main(*args, **kwargs)
2022-05-22T07:51:31.5085416Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/click/core.py", line 1055, in main
2022-05-22T07:51:31.5085517Z     rv = self.invoke(ctx)
2022-05-22T07:51:31.5086115Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/cli.py", line 99, in invoke
2022-05-22T07:51:31.5086216Z     super().invoke(ctx)
2022-05-22T07:51:31.5086587Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
2022-05-22T07:51:31.5086749Z     return _process_result(sub_ctx.command.invoke(sub_ctx))
2022-05-22T07:51:31.5087118Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
2022-05-22T07:51:31.5087262Z     return ctx.invoke(self.callback, **ctx.params)
2022-05-22T07:51:31.5087610Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/click/core.py", line 760, in invoke
2022-05-22T07:51:31.5087723Z     return __callback(*args, **kwargs)
2022-05-22T07:51:31.5088132Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/cli.py", line 464, in check_manifest
2022-05-22T07:51:31.5088305Z     util.run("check-manifest -v")
2022-05-22T07:51:31.5088676Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/util.py", line 88, in run
2022-05-22T07:51:31.5088762Z     raise e
2022-05-22T07:51:31.5089136Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/util.py", line 80, in run
2022-05-22T07:51:31.5089244Z     process = tee(cmd, **kwargs)
2022-05-22T07:51:31.5089677Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/tee.py", line 155, in run
2022-05-22T07:51:31.5089847Z     raise subprocess.CalledProcessError(
2022-05-22T07:51:31.5090177Z subprocess.CalledProcessError: Command 'check-manifest -v' returned non-zero exit status 1.
2022-05-22T07:51:31.5580733Z Traceback (most recent call last):
2022-05-22T07:51:31.5583177Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/runpy.py", line 197, in _run_module_as_main
2022-05-22T07:51:31.5702661Z     return _run_code(code, main_globals, None,
2022-05-22T07:51:31.5703103Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/runpy.py", line 87, in _run_code
2022-05-22T07:51:31.5703432Z     exec(code, run_globals)
2022-05-22T07:51:31.5704201Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/actions/draft_release.py", line 74, in <module>
2022-05-22T07:51:31.5704680Z     run_action("jupyter-releaser check-manifest")
2022-05-22T07:51:31.5709441Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/actions/common.py", line 36, in run_action
2022-05-22T07:51:31.5709828Z     _run(target, *args, **kwargs)
2022-05-22T07:51:31.5710524Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/util.py", line 88, in run
2022-05-22T07:51:31.5710865Z     raise e
2022-05-22T07:51:31.5711335Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/util.py", line 80, in run
2022-05-22T07:51:31.5711700Z     process = tee(cmd, **kwargs)
2022-05-22T07:51:31.5712212Z   File "/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/jupyter_releaser/tee.py", line 155, in run
2022-05-22T07:51:31.5712619Z     raise subprocess.CalledProcessError(
2022-05-22T07:51:31.5713145Z subprocess.CalledProcessError: Command 'jupyter-releaser check-manifest' returned non-zero exit status 1.

blink1073 · 2022-05-22T12:20:15Z

It might be worth waiting until we switch over to using hatch_jupyter_builder, setuptools is more trouble than it is worth.

blink1073 · 2022-05-22T12:20:37Z

Otherwise I'd suggest running check manifest -v locally to see if you get a better error message.

echarles · 2022-05-22T13:15:43Z

Thx @blink1073 for the help and advices. python setup.py sdist && check-manifest -v run fine with success on my local env with this branch.

It may be worth moving to hatch_jupyter_builder, which we will need to do anyway. Sorry, my wifi dropped at the last community meeting where you would talk about hatch jupyter builder. Is it already usable today. What would be the steps to move to that?

blink1073 · 2022-05-23T11:12:37Z

I'd like to complete all the steps outlined in the JupyterLab PR before declaring it ready. For now, you can add check-manifest to the tool.jupyter-releaser skip array.

echarles · 2022-05-23T11:38:43Z

I have disabled the check-manifest as suggested and now check_release (check_release) is green. I keep track on all things disabled on #100 (comment)

Moving further, the check_release (link_check) is failing with (see https://github.com/jupyter/nbclassic/runs/6554168676?check_suite_focus=true).

=================================== FAILURES ===================================
_ /home/runner/work/nbclassic/nbclassic/.jupyter_releaser_checkout/nbclassic/static/components/font-awesome/README.md: http://fortawesome.github.com/Font-Awesome/ _
http://fortawesome.github.com/Font-Awesome/: 404: Not Found
_ /home/runner/work/nbclassic/nbclassic/.jupyter_releaser_checkout/nbclassic/static/components/font-awesome/README.md: http://scripts.sil.org/OFL _
http://scripts.sil.org/OFL: Exceeded 30 redirects.
_ /home/runner/work/nbclassic/nbclassic/.jupyter_releaser_checkout/nbclassic/static/components/font-awesome/README.md: http://fortawesome.github.com/Font-Awesome _
http://fortawesome.github.com/Font-Awesome: 404: Not Found

echarles · 2022-05-25T04:16:33Z

@blink1073 I have undrafted this. We could merge this PR which disables the make the check_release green and migrate to hatch when ready. I have listed that action in #100 (comment)

echarles · 2022-05-25T04:17:09Z

I will tackle the failure for the other subflow link_check in another PR.

blink1073 · 2022-05-25T10:57:07Z

Sounds good, thanks!

echarles · 2022-05-25T11:00:16Z

Super! Thx @blink1073

echarles added 3 commits May 20, 2022 13:02

use _version.py in pyproject.toml

a29f818

manually bump version to 0.3.8.dev0

ee0e6c1

manually bump version to 0.3.7

200fc88

echarles mentioned this pull request May 20, 2022

Correct version python file? #101

Closed

echarles added 2 commits May 20, 2022 16:34

add settings for jupyter-releaser in pyproject.toml

705b1c2

use nbclassic as name for po and mo files

2fc5269

echarles added the enhancement New feature or request label May 20, 2022

echarles changed the title ~~Use _version.py in pyproject.toml~~ Fix Check Release / check_release CI job May 20, 2022

echarles mentioned this pull request May 20, 2022

[CI] Fix or disable jobs to get a 100% green CI #100

Open

5 tasks

echarles added 4 commits May 21, 2022 08:20

add missing files in MANIFEST.in

9764423

add missing files in MANIFEST.in

6ca8744

add suggested rues in MANIFEST.in

f6e80bd

add more rules in MANIFEST.in

148ac77

blink1073 reviewed May 21, 2022

View reviewed changes

echarles added 4 commits May 21, 2022 17:25

prune instead of exclude in manifest.in

e5d80d1

update manifest.in

0f70fc8

update manifest.in

04c44f9

update manifest.in

95cce70

skip check-manifest for now waiting on hatch availability

a81eb2a

echarles marked this pull request as ready for review May 25, 2022 04:13

blink1073 merged commit 0245548 into jupyter:main May 25, 2022

afshin mentioned this pull request May 26, 2022

Notebook Weekly Meetings Nov 2021 - Dec 2022 jupyter/notebook-team-compass#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `Check Release / check_release` CI job #102

Fix `Check Release / check_release` CI job #102

echarles commented May 20, 2022

blink1073 commented May 20, 2022

echarles commented May 20, 2022

blink1073 commented May 20, 2022

echarles commented May 21, 2022

blink1073 May 21, 2022

echarles commented May 22, 2022

blink1073 commented May 22, 2022

blink1073 commented May 22, 2022

echarles commented May 22, 2022

blink1073 commented May 23, 2022

echarles commented May 23, 2022 •

edited

Loading

echarles commented May 25, 2022

echarles commented May 25, 2022

blink1073 commented May 25, 2022

echarles commented May 25, 2022

Fix Check Release / check_release CI job #102

Fix Check Release / check_release CI job #102

Conversation

echarles commented May 20, 2022

blink1073 commented May 20, 2022

echarles commented May 20, 2022

blink1073 commented May 20, 2022

echarles commented May 21, 2022

blink1073 May 21, 2022

Choose a reason for hiding this comment

echarles commented May 22, 2022

blink1073 commented May 22, 2022

blink1073 commented May 22, 2022

echarles commented May 22, 2022

blink1073 commented May 23, 2022

echarles commented May 23, 2022 • edited Loading

echarles commented May 25, 2022

echarles commented May 25, 2022

blink1073 commented May 25, 2022

echarles commented May 25, 2022

Fix `Check Release / check_release` CI job #102

Fix `Check Release / check_release` CI job #102

echarles commented May 23, 2022 •

edited

Loading