Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating JS Dependencies #152

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Updating JS Dependencies #152

merged 3 commits into from
Sep 17, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Sep 15, 2022

No description provided.

@echarles
Copy link
Member

Thx @RRosio for starting this. I see various failures on the CI. Just wanted to checkpoint with you to confirm (or not) that this branch is running fine on your local env. If that is the case, there maybe a root cause to all those CI failures we should look at?

@RRosio
Copy link
Collaborator Author

RRosio commented Sep 16, 2022

Hi @echarles, yes locally these changes still allow a successful install and work normally. I am taking a look through the errors since all of the CI tests fail to find one of the files associated with the jQuery package although I updated the file path in the templates, I realized I missed updating the path to jQuery in tools/build-main.js. I just pushed those updates and if that was not the problem maybe it would be best to look at the CI tests

@RRosio RRosio marked this pull request as ready for review September 16, 2022 15:11
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @RRosio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants