Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading of static and template path config #192

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 13, 2023

these config options were ignored because the path attributes were defined several times, each overriding the last.

The final loaded version that's actually used ignored configuration, making it impossible to load custom template config.

these config options were ignored because the path attributes were defined several times,
each overriding the last
@minrk minrk added the bug Something isn't working label Jan 16, 2023
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx @minrk

@echarles echarles merged commit ac3fafc into jupyter:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants