Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to marked 4.0.10 #201

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Upgrade to marked 4.0.10 #201

merged 4 commits into from
Jan 24, 2023

Conversation

echarles
Copy link
Member

Fixes #200

@echarles echarles requested a review from RRosio January 24, 2023 06:45
@echarles echarles marked this pull request as draft January 24, 2023 07:02
@echarles echarles added the dependencies Pull requests that update a dependency file label Jan 24, 2023
@echarles echarles marked this pull request as ready for review January 24, 2023 07:43
@echarles echarles added the enhancement New feature or request label Jan 24, 2023
@RRosio
Copy link
Collaborator

RRosio commented Jan 24, 2023

Hi @echarles, thank you for the ping to review! I was trying this out locally before merging and I noticed some weird behavior with trying to change a code cell to a markdown cell. Instead of converting the cell the via Esc + M or the menu option, an empty white line was added after the cells. I'm wondering if this is something present for you as well? It seems the version of marked that my system is grabbing upon install is 4.0.19.

Screen.Recording.2023-01-24.at.6.56.32.AM.mov

@echarles
Copy link
Member Author

Great catch @RRosio. My last commit should fix the issue you have pointed.

4.0.19 is the latest one that respects ~4.0.10.

@RRosio
Copy link
Collaborator

RRosio commented Jan 24, 2023

@echarles awesome thank you! Indeed that issue no longer appears! I'll merge this in!

@RRosio RRosio merged commit 1eab076 into jupyter:main Jan 24, 2023
@echarles
Copy link
Member Author

Thx @RRosio

@mwyschan mwyschan mentioned this pull request Feb 21, 2023
Closed
@echarles echarles mentioned this pull request Feb 28, 2023
Closed
@echarles echarles mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRosio RRosio Awaiting requested review from RRosio

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS dependency marked is out of date
2 participants
@echarles @RRosio