Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency requirements to minimum necessary #259

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Aug 4, 2023

Addresses #252, removing the duplicate dependencies carried over by notebook-shim's dependency on jupyter-server.

@RRosio RRosio added the dependencies Pull requests that update a dependency file label Aug 4, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Those can likely be cleaned up for the conda package as a follow-up after the next release of nbclassic: https://github.com/conda-forge/nbclassic-feedstock

@RRosio
Copy link
Collaborator Author

RRosio commented Aug 11, 2023

Sounds good, I will keep that in mind for the next release, thanks for the approval @jtpio!
I'll go ahead and merge this!

@RRosio RRosio merged commit addf6de into jupyter:main Aug 11, 2023
22 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants