Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 #142

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 #142

merged 1 commit into from
Jun 13, 2019

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Jun 13, 2019

  • As agreed during Jupyterhub for research facilities sprint.
  • For now, test PR to see what works on Travis currently.

@rkdarst rkdarst changed the title Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 [wip] Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 Jun 13, 2019
@rkdarst
Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5
14ed789 
- As agreed during Jupyterhub for research facilities sprint, jupyterhub#138
@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 13, 2019

Nice, all tests pass now by default when we drop the old versions. Upcoming commit will clean up a bit then I guess this is ready to go.

Can someone kick travis to re-run tests on important old PRs? My own PRs, I'll rebase.

@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 13, 2019

Passes - can someone merge?

@rkdarst rkdarst changed the title [wip] Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 Jun 13, 2019
@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 13, 2019

Note: accepting this will begin testing on 1.0, which requires some previous key PRs to also be changed. I am working on an integration of them all that works.

@mbmilligan mbmilligan merged commit 1bd1e2a into jupyterhub:master Jun 13, 2019
@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 13, 2019

Thanks!

Could you accept jupyterhub/wrapspawner#27? That will be required for upcoming fixes to batchspawner, and better to do that first than work around.

@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 13, 2019

Actually maybe not strictly needed for the general case without wrapspawner...

@rkdarst rkdarst deleted the compat_3.5_0.9 branch June 13, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkdarst @mbmilligan