Singleuserapp and 1.0 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a batchspawner notebook app, batchspawner-singleuser is now a wrapper that finds a port and add the port number to the command-line argument of the singleuser app. This allows the usage of batchspawner with jupyterlab for example.
- jupyterhub#139 changes port handling, this makes tests pass. - Sets attribute mock_port, which gets used during the port polling phase.
- Fixes tests for PR jupyterhub#139
This was referenced Jun 14, 2019
…apper - This fixes up tests for jupyterhub#141, which adds batchspawner-singleuser which changes regular expressions that need to be matched in the batch scripts.
This was referenced Jun 16, 2019
|
Great, thanks for pulling these together. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines different things which have to go together to make it all work:
This at least minimally works for me in my test environment against current JH master!
jupyterhub/wrapspawner#27 has to be accepted too, or else it won't work out of the box with wrapspawner. maybe it will work here.