Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ sign in the filename - won't work with Windows #58

Closed
consideRatio opened this issue Oct 19, 2019 · 1 comment
Closed

+ sign in the filename - won't work with Windows #58

consideRatio opened this issue Oct 19, 2019 · 1 comment

Comments

@consideRatio
Copy link
Member

consideRatio commented Oct 19, 2019

In #52 I added a + sign to the helm chart version, but the Helm chart version is used to construct a filename when we use --publish-chart. If this would be done on a windows computer, we would crash I think.

We should probably when working with the filename instead build to a filename where we replace + with _. What's important though, is that everything still works when updating and adding the files to index.yaml, so that the chart version we get from there still relies on +.


Wait, it may work... I don't know.

@consideRatio
Copy link
Member Author

We no longer use + signs, but it wouldn't been an issue anyhow I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant