Chart and image versioning, and Chart.yaml's --reset interaction #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- preserves prerelease category (alpha, beta, etc.)
- use '0' if no prerelease category is set
- chart version has the form `x.y.z-{alpha|beta|rc|0}.n.sha` where `n` is commits since tag,
sha is current commit
Image tags are now set like the chart versions are set, but where + has been replaced with _ as is required to be a valid docker tag. ``` <latest chart tag>_<n commits since>-<last image commit> ``` Note that `git rev-list --count <commit_nr_10>..<commit_nr_5>` would return 0 while the reverse ordering would return 5.
Here is a build that should have failed, that this commit ensures will fail in the future: https://travis-ci.org/jupyterhub/chartpress/builds/598821781
consideRatio
force-pushed
the
describe
branch
from
04ae310
to
582d429
Compare
|
Awesome! |
This was referenced Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @minrk's PR #33 where I implement my suggestion in #33 (comment).
+<n_commits_since_tag>.<last_chart_modifying_commit>, which results in a valid formatted SemVer 2 version.+is replaced with_to comply with the allowed characters of docker tags.--resetinteraction be to reset the version field to something fixed. This closes PR Discussion: chartpress --reset on the Chart.yaml #44 using the idea in PR Discussion: chartpress --reset on the Chart.yaml #44 (comment). This change required the first point.Example diff after chartpress is run on Z2JH
Note how it claims that the latest tag is 0.8.0, and that is actually true, it is the latest tagged commit in the git history of z2jh's master. For some reason, 0.8.1 and 0.8.2 tags commit not part of the master commit history. I consider this something that should be fixed in z2jh rather than adjust this PRs chartpress logic which I think makes sense.