Skip to content

Commit

Permalink
Merge pull request #289 from jupyterhub/dependabot/npm_and_yarn/comma…
Browse files Browse the repository at this point in the history
…nder-7.1.0

Bump commander from 6.2.1 to 7.1.0
  • Loading branch information
minrk authored Mar 5, 2021
2 parents 2417b11 + a398329 commit 15ac3af
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ name: Test

on:
push:
branches-ignore:
# don't double-build dependabot PRs
- dependabot/**
pull_request:
workflow_dispatch:

Expand Down
7 changes: 4 additions & 3 deletions bin/configurable-http-proxy
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@

var fs = require("fs"),
pkg = require("../package.json"),
args = require("commander"),
cli = require("commander"),
tls = require("tls"),
winston = require("winston");

args
cli
.version(pkg.version)
.option("--ip <ip-address>", "Public-facing IP of the proxy")
.option("--port <n> (defaults to 8000)", "Public-facing port of the proxy", parseInt)
Expand Down Expand Up @@ -117,7 +117,8 @@ function collectHeadersIntoObject(value, previous) {
previous[headerParts[0]] = headerParts[1];
}

args.parse(process.argv);
cli.parse(process.argv);
var args = cli.opts();

var ConfigurableProxy = require("../lib/configproxy.js").ConfigurableProxy;

Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"url": "https://github.com/jupyterhub/configurable-http-proxy.git"
},
"dependencies": {
"commander": "~6.2.0",
"commander": "~7.1.0",
"http-proxy": "^1.18.1",
"lynx": "^0.2.0",
"strftime": "~0.10.0",
Expand Down

0 comments on commit 15ac3af

Please sign in to comment.