adopt pre-commit #291
Merged
adopt pre-commit #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run prettier for autoformatting most files (beautysh for shell)
Javascript already formatted, autoformatting applied to the rest
to catch actual errors
- move redundant ca setup to a function - remove unnecessary escapes in regex - avoid hasOwnProperty for some reason
consideRatio
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run fmtwhich ran prettier on jseslintand address a couple linter messagesThe only reason not to do this is because pre-commit is a Python package and the js-community generally uses husky to do things like pre-commit hooks.
On the other hand, the rest of JupyterHub uses pre-commit, and that's who contributes here.