Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for last-activity updates #293

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 5, 2021

tests for #292 - both that the usual activity is unchanged for simple successful requests, and that activity is not updated for failed requests

@consideRatio
Copy link
Member

consideRatio commented Mar 5, 2021

Node 10 LTS will reach end of life 2021-04-30, perhaps our next release should just stop supporting Node 10?

EDIT: https://nodejs.org/en/about/releases/

@minrk
Copy link
Member Author

minrk commented Mar 5, 2021

I think I'd rather use Ubuntu LTS as baseline supported node, given how little we need from it, unless there's a big reason to cut people off. 16.04 reaches end-of-maintenance this April, at which point 18.04 will be the oldest LTS release, which ships with node 8.

@consideRatio consideRatio merged commit ec998cd into jupyterhub:master Mar 5, 2021
@minrk minrk deleted the activity-on-success branch March 5, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants