Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend changelog about dropping statsd #317

Merged
merged 2 commits into from
May 26, 2021
Merged

Amend changelog about dropping statsd #317

merged 2 commits into from
May 26, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 26, 2021 •
edited
Loading

See discussion in #316 (comment) for a background to this.

@consideRatio consideRatio requested a review from manics May 26, 2021 14:03
mriedem
mriedem approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions inline but otherwise looks good to me, thanks for the quick follow up.

CHANGELOG.md Outdated Show resolved Hide resolved
@consideRatio @mriedem
Apply suggestions from code review
ea2d30b 
Co-authored-by: Matt Riedemann <mriedem.os@gmail.com>
mriedem
mriedem approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@consideRatio consideRatio merged commit 790a8c7 into jupyterhub:main May 26, 2021
@consideRatio
Copy link
Member Author

Thanks @mriedem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriedem mriedem mriedem approved these changes

@manics manics Awaiting requested review from manics

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consideRatio @mriedem