Require node 12+ explicitly #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
approved these changes
Jun 4, 2021
|
@manics not to my knowledge, I'm not feeling so capable pushing additional features or fixes if there were either though as I'm not feeling confident in writing code for this repo. |
|
👍 Note that making a release dropping node support won't immediately or obviously affect any users with old node, since they will just get old CHP to match. We might also consider yanking 4.4 since it has an invalid dependency spec, and adding this restriction to 5.0 just means that users with node 8 will continue to get 4.4. |
|
Note that the README still says "Node >= 6" in the Install section. |
|
@kgutwin do you want to submit a PR fixing it? =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have failed to require a version of node which we test, which have resulted in failures for those with older versions of node. See for example #321 where node 8 caused problems. I suggest we transition properly to require node 12 at this point which is the oldest version of node with Long Term Support that is actively maintained still.
I figure we could cut a 5.0.0 release with this. In a way it is a bugfix to require node 10 as of 4.4.0 which broke with node 8, and it is a breaking change to require node 12 as node 10 have actually been functional I think. Note though that node 10 have had intermittent test failures while the other versions hasn't.
Since we have flaky tests for node 10, and I don't think our time is merited to debug and support that in detail any more, I suggest we go for node 12 and release CHP 5.0.0.
closes #322