Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix details in workflows causing duplicated builds and a failure #326

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jun 25, 2021

When dependabot triggered a build, the publish-docker job in the publish workflow would fail because...

error: invalid tag "jupyterhub/configurable-http-proxy:dependabot/npm_and_yarn/jshint-2.13.0": invalid reference format
Error: buildx call failed with: error: invalid tag "jupyterhub/configurable-http-proxy:dependabot/npm_and_yarn/jshint-2.13.0": invalid reference format

With this PR, we disable push triggered tests to trigger when dependabot pushes a dependabot/ prefixed branch, but we still trigger the pull_request triggered tests and such that works well still.

@consideRatio consideRatio merged commit a409cae into jupyterhub:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant