Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a node shouldn't delete all children #93

Merged
merged 3 commits into from
Jan 26, 2017
Merged

Deleting a node shouldn't delete all children #93

merged 3 commits into from
Jan 26, 2017

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 25, 2017

closes #92

@minrk minrk mentioned this pull request Jan 25, 2017
Closed
@rgbkrk
Copy link
Member

rgbkrk commented Jan 26, 2017

The error looks related to the change here, in that remove is called on the child. Is that the test no longer being valid or is this now missing a case?

@minrk
Copy link
Member Author

minrk commented Jan 26, 2017

Thanks! It was mostly a coincidence that the test was passing, since the error would only be avoided when the removal was one-level deep. .remove('/a/b/c') triggers the same error in master. I've fixed the failure and made the test more rigorous.

@minrk minrk merged commit e52764b into jupyterhub:master Jan 26, 2017
@minrk minrk deleted the no-delete-if-children branch January 26, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot delete child route after deleting parent route
2 participants
@minrk @rgbkrk