Support EnvVar's with 'valueFrom' as well as with 'value' #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
added a commit
to consideRatio/zero-to-jupyterhub-k8s
that referenced
this pull request
Sep 1, 2020
Note this commit relies on a KubeSpawner PR currently not merged. See jupyterhub/kubespawner#426.
consideRatio
added a commit
to consideRatio/zero-to-jupyterhub-k8s
that referenced
this pull request
Sep 1, 2020
Note this commit relies on a KubeSpawner PR currently not merged. See jupyterhub/kubespawner#426.
2 tasks
|
The more we can just pass through to k8s, the better. Thanks for the PR, @consideRatio |
|
Thanks @yuvipanda! ❤️ 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The c.KubeSpawner.environment configuration can only accept a dictionary with keys and values being strings, because they will be passed as name and value to the name and value parameters of the EnvVar resource. But, Kubernetes EnvVar resources can have a name / valueFrom combo as well.
Due to this limitation, users ended up forced to do something very obscure like described jupyterhub/zero-to-jupyterhub-k8s#1103 (comment).
Solution
In this PR I enable users to pass other kinds of structures as well that will allow for any kind of valid k8s EnvVar structure to be passed. The format is best documented in the test currently.
References
environmenttraitlet that KubeSpawner leaves untouched.