Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing Z2JH #228

Closed
27 of 30 tasks
consideRatio opened this issue Nov 19, 2019 · 18 comments
Closed
27 of 30 tasks

Releasing Z2JH #228

consideRatio opened this issue Nov 19, 2019 · 18 comments

Comments

@consideRatio
Copy link
Member

consideRatio commented Nov 19, 2019

@jupyterhub/jupyterhubteam I'd love to see a Z2JH release be made, so I'm reaching out for help to accomplish that. What's missing mostly is making releases of other dependent projects, so we can bump them in z2jh. If you have time to spare, I'd like your help to take these repositories towards a release!

z2jh dependency release checklist

z2jh itself checklist

@choldgraf
Copy link
Member

I agree it would be fantastic to get a new release out. Perhaps we can post this issue on the community forum as well?

@consideRatio
Copy link
Member Author

@betatim i've now updated tasks of relevance and put in some work myself already. @manics shall we try making a release. Inspecting the PR lists of the repositories and helping me verify that it makes sense to make a release in the current state is relevant help for example.

@choldgraf
Copy link
Member

Just a quick thought from me: it would be awesome if we could get the new documentation PR merged in /jupyterhub before a new release is made, since the documentation there is for stable/ by default, not latest/

@consideRatio
Copy link
Member Author

Attention specifically to:

@consideRatio
Copy link
Member Author

I've made a release of oauthenticator now, and up comes kubespawner, and then we have jupyterhub itself left!

@consideRatio
Copy link
Member Author

Review help request:

I'll go ahead and release kubespawner after this using the @manics setup pattern to do PyPI CD by pushing a git tag.

It almost worked with oauthenticator, next try is with kubespawner :)

@consideRatio
Copy link
Member Author

Kubespawner is now released and I got Z2JH to work on k8s 1.16, and I submitted PRs to fix binderhub for k8s 1.16 as well. See jupyterhub/binderhub#1012 and jupyterhub/binderhub#1013.

@consideRatio
Copy link
Member Author

Prio to resolve: jupyterhub/zero-to-jupyterhub-k8s#1501

@consideRatio
Copy link
Member Author

A jupyterhub release would be nice to reference, but nothing that should stop us from releasing alpha/beta of z2jh using current master instead. Most things have come around now.

@mjuric
Copy link

mjuric commented Dec 6, 2019

Apologies if this has an obvious answer, but does one of the recent alpha releases include the kubespawner with the jupyterhub/zero-to-jupyterhub-k8s#1501 fix?

(more generally, is there a way to quickly see which commits/releases of individual packages -- spawner, hub, etc -- went into each alpha-series Helm chart + hub images)?

@consideRatio
Copy link
Member Author

No obvious answer, yepp the latest does for example!

We dont have a way to track dependencies for chart releases yet :/ it would be nice to have some pip freeze or similar provided someplace.

@consideRatio
Copy link
Member Author

@mjuric you correctly identified a bug, it is resolved by jupyterhub/zero-to-jupyterhub-k8s#1518.


I also identified issues with the ltiauthenticator that needs to be solved, I made a few PRs to do so to the best of my ability, but there is one commit in jupyterhub/ltiauthenticator#26 that require a review by someone with more background understanding about the code base.

@consideRatio
Copy link
Member Author

jupyterhub/litauthenticator issues resolved!

@consideRatio
Copy link
Member Author

I'd be fine making a beta-release of z2jh - should we make it reference a jupyterhub beta release first or not?

@manics
Copy link
Member

manics commented Dec 11, 2019

If the final z2jh release will include a new jupyterhub release I think it makes sense to tag a jupyterhub beta too and include it in the Z2JH beta, so that it gets some testing.

@consideRatio
Copy link
Member Author

Z2JH 0.9.0 released 🌻

@consideRatio
Copy link
Member Author

@choldgraf
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants