Add "selector" to BinderHub Deployment object for k8s 1.16 #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also need to bump to a k8s 1.16 compateble z2jh helm chart release, as the user-scheduler isn't working currently with k8s 1.16 for example.
consideRatio
changed the title
sgibson91
approved these changes
Nov 27, 2019
consideRatio
commented
Nov 27, 2019
| matchLabels: | ||
| app: binder | ||
| component: binder | ||
| release: {{ .Release.Name }} |
There was a problem hiding this comment.
note btw that I left out some labels here, it is not considered good practice selecting on some, such as heritage: tiller which is good because it is gone in helm 3 :D
This was referenced Nov 28, 2019
betatim
changed the title
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need to bump to a k8s 1.16 compateble z2jh helm chart release,
as the user-scheduler isn't working currently with k8s 1.16 for example.
Closes #1011