Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more configurable options in helm chart #1338

Merged
merged 2 commits into from
Sep 6, 2019
Merged

more configurable options in helm chart #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2b5831
add more configurable options into chart
bitnik Jul 26, 2019
4bbd157
Apply suggestions from code review
bitnik Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions images/hub/jupyterhub_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ def camelCaseify(s):
# base url prefix
('base_url', None),
('allow_named_servers', None),
('named_server_limit_per_user', None),
('authenticate_prometheus', None),
('redirect_to_server', None),
('shutdown_on_logout', None),
('template_paths', None),
('template_vars', None),
):
if cfg_key is None:
cfg_key = camelCaseify(trait)
Expand Down Expand Up @@ -127,6 +133,7 @@ def camelCaseify(s):
('extra_resource_guarantees', 'extraResource.guarantees'),
('environment', 'extraEnv'),
('profile_list', None),
('extra_pod_config', None),
):
if cfg_key is None:
cfg_key = camelCaseify(trait)
Expand Down Expand Up @@ -235,8 +242,6 @@ def camelCaseify(s):
c.KubeSpawner.volumes.extend(get_config('singleuser.storage.extraVolumes', []))
c.KubeSpawner.volume_mounts.extend(get_config('singleuser.storage.extraVolumeMounts', []))

set_config_if_not_none(c.KubeSpawner, 'lifecycle_hooks', 'singleuser.lifecycleHooks')

# Gives spawned containers access to the API of the hub
c.JupyterHub.hub_connect_ip = os.environ['HUB_SERVICE_HOST']
c.JupyterHub.hub_connect_port = int(os.environ['HUB_SERVICE_PORT'])
Expand Down
7 changes: 7 additions & 0 deletions jupyterhub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ hub:
- ipBlock:
cidr: 0.0.0.0/0
allowNamedServers: false
namedServerLimitPerUser:
authenticatePrometheus:
redirectToServer:
shutdownOnLogout:
templatePaths: []
templateVars: {}


rbac:
Expand Down Expand Up @@ -225,6 +231,7 @@ singleuser:
guarantees: {}
cmd: jupyterhub-singleuser
defaultUrl:
extraPodConfig: {}


scheduling:
Expand Down