Allow adding additional ingress rules in network policy #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a prometheus server in a different namespace, explicit 'from' stanzas are needed to make sure it can have access to your hub and user pods. This change allows individual administrators to make these changes.
Change networkPolicy.ingress to have same structure as networkPolicy.egress. However, leave default ingress rule in place so users don't accidentally break the hub
yuvipanda
added a commit
to yuvipanda/datahub-old-fork
that referenced
this pull request
Aug 30, 2019
Adds a prometheus / grafana chart that uses GitHub for authentication. Currently, prometheus can't reach into hub / singleuser servers, since z2jh doesn't support cross-namespace networkpolicy. jupyterhub/zero-to-jupyterhub-k8s#1380 should fix that.
|
This LGTM! I like the change from extraRules to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a prometheus server in a different namespace,
explicit 'from' stanzas are needed to make sure it can
have access to your hub and user pods.
This change allows individual administrators to make
these changes.