Commits on Sep 10, 2019

1. Recreate proxy deployment strategy …

   Using a rolling update by default on the proxy pod is a mistake by us,
   because of the JupyterHub / CHP proxy interaction. JupyterHub assumes in
   check_routes / add_route etc to be speaking to one specific CHP proxy
   server, but there can be different ones responding if we make an upgrade
   and the proxy pod is making a rolling upgrade.
   
   For example, consider a hub pod making a recreate upgrade, and a proxy
   pod makinga rolling upgrade. The new hub pod could for example get ready
   before the proxy pod and start speaking with the old proxy pod and later
   at a crucial point start speaking with the new pod. If you switch to
   speaking with the new pod at the wrong time, you may end up with failure
   to get responses from user pods that are verified to be around, and then
   they are deleted.
   
   So, this commit hope to fix a sneaky bug where user pods are deleted
   during upgrades where the proxy pod is also updated!

   

   consideRatio committed Sep 10, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 4bb76c7
   • Browse repository at this point

   Copy the full SHA

   4bb76c7 View commit details

   Browse the repository at this point in the history