[MRG] Update step zero for Azure docs with commands to setup an VNet and network policy #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Erik Sundell <erik.i.sundell@gmail.com>
sgibson91
changed the title
sgibson91
commented
Dec 20, 2019
sgibson91
changed the title
betatim
reviewed
Jan 9, 2020
|
LGTM. One language nit. If you can merge please do just merge this after the nit @sgibson91 otherwise I'll circle back on this. The duplication of the instructions in the "setup for autoscaling" and "setup no autoscaling" is unfortunate, maybe something we can ponder (or already have pondered?) in a new issue. |
Yes, I think @willingc had the idea of "Build Your Own Adventure" style docs during the Oslo meeting. |
Co-Authored-By: Tim Head <betatim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Step Zero docs for Azure k8s to create a virtual network into which the cluster is deployed. This is because k8s does not come with a network controller by default and so the
networkpolicyresources installed by a helm chart will not be obeyed.fixes #1526