Tighten and flesh out networkpolicies #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
netpol-flesh-out
branch
from
b4cfcf6
to
bf4d24e
Compare
consideRatio
force-pushed
the
netpol-flesh-out
branch
from
16f7988
to
db19e10
Compare
9 tasks
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone wanted to restrict the egress, they would previously need quite a bit of exceptions. With this setup, I hope to make them function even though the Helm chart user removes denies all not explicitly allowed egress by removing the explicit allowance of 0.0.0.0/0 (all IPv4 egress).
UPDATE
This PR introduced a breaking change. All traffic towards the proxy pod, for example through the proxy-public service, must now be from pods labelled with
hub.jupyter.org/network-access-proxy-http: "true"or from pods in a namespace labelled withhub.jupyter.org/network-access-proxy-http: "true".That this wasn't already the case, is considered a bug fix.