Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for hub/proxy/autohttps container's securityContext #1708

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Add config for hub/proxy/autohttps container's securityContext #1708

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30a3af4
Allow overriding hub container securityContext
mriedem Jul 2, 2020
03c88a4
Deprecate .Values.hub.uid
mriedem Jul 6, 2020
8024257
Handle hub.uid being 0 in deprecation note logic
mriedem Jul 6, 2020
d1daf01
Allow setting securityContext of hub/proxy/autohttps containers
consideRatio Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jupyterhub/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,11 @@ custom:
WARNING: You are using user placeholders without pod priority enabled, either
enable pod priority or stop using the user placeholders to avoid wasting cloud
resources.
{{- end }}

{{- if .Values.hub.uid }}

DEPRECATION: hub.uid is deprecated in jupyterhub chart 0.9. Set the hub.containerSecurityContext.runAsUser value
directly instead.

mriedem marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
4 changes: 1 addition & 3 deletions jupyterhub/templates/hub/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,7 @@ spec:
imagePullPolicy: {{ . }}
{{- end }}
securityContext:
runAsUser: {{ .Values.hub.uid }}
# Don't allow any process to execute as root inside the container
allowPrivilegeEscalation: false
{{- .Values.hub.containerSecurityContext | toYaml | trimSuffix "\n" | nindent 12 }}
env:
- name: PYTHONUNBUFFERED
value: "1"
Expand Down
5 changes: 4 additions & 1 deletion jupyterhub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ hub:
cookieSecret:
publicURL:
initContainers: []
uid: 1000
fsGid: 1000
nodeSelector: {}
concurrentSpawnLimit: 64
Expand Down Expand Up @@ -55,6 +54,10 @@ hub:
requests:
cpu: 200m
memory: 512Mi
containerSecurityContext:
runAsUser: 1000
# Don't allow any process to execute as root inside the container
allowPrivilegeEscalation: false
consideRatio marked this conversation as resolved.
Show resolved Hide resolved
services: {}
imagePullSecret:
enabled: false
Expand Down