Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prePuller.extraTolerations added for the image-puller daemonsets #1883

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

jerkern
Copy link
Contributor

@jerkern jerkern commented Oct 28, 2020

Adding exclusive extra tolerations to the prePuller daemonset, to make it easier to integrate into a deployment that uses eg. nidhogg for dynamic tainting.
Related to issue #1836 and #1851 . This doesn't fully solve the problem, it just makes it easier to do a custom solution.

Example use-case

  • nidhogg taints all nodes while the prePuller is running, prohibiting anything except the prePuller from being assigned to the node
  • prePuller completes and nidhogg removes the taint
  • now placeholder and actual user pods can be deployed to the node

This PR accomplishes being able to add a taint that only is tolerated by the prePuller and nothing else.

@welcome
Copy link

welcome bot commented Oct 28, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

jupyterhub/values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @jerkern! This looks sensible and thank you for providing documentation for everyone else about the motivation of this PR even though we discussed it verbally before.

After these parts are addressed I think we can merge.

  • Let the configuration for job.yaml (image-awaiter) in prePuller.hook.tolerations remain
  • Add a valid entry in lint-and-validate-config.yaml for the new tolerations, then run tools/templates/lint-and-validate.py to see that we render into valid k8s resources still.

Bonus:

  • See if you can rebase on current master to avoid inclusion of unrelated commits in git history.

@consideRatio consideRatio changed the title prepuller extra tolerations prePuller.extraTolerations added for the image-puller daemonsets Oct 28, 2020
@donotpush
Copy link

@consideRatio we updated the PR based on your comments

@consideRatio consideRatio merged commit a16f87e into jupyterhub:master Nov 3, 2020
@welcome
Copy link

welcome bot commented Nov 3, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

Thank you @jerkern and @donotpush! 🎉 ❤️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants