-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prePuller.extraTolerations added for the image-puller daemonsets #1883
Conversation
added prepuller.extraTolerations to chart schema
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @jerkern! This looks sensible and thank you for providing documentation for everyone else about the motivation of this PR even though we discussed it verbally before.
After these parts are addressed I think we can merge.
- Let the configuration for job.yaml (image-awaiter) in prePuller.hook.tolerations remain
- Add a valid entry in lint-and-validate-config.yaml for the new tolerations, then run
tools/templates/lint-and-validate.py
to see that we render into valid k8s resources still.
Bonus:
- See if you can rebase on current master to avoid inclusion of unrelated commits in git history.
@consideRatio we updated the PR based on your comments |
Thank you @jerkern and @donotpush! 🎉 ❤️! |
Adding exclusive extra tolerations to the prePuller daemonset, to make it easier to integrate into a deployment that uses eg. nidhogg for dynamic tainting.
Related to issue #1836 and #1851 . This doesn't fully solve the problem, it just makes it easier to do a custom solution.
Example use-case
This PR accomplishes being able to add a taint that only is tolerated by the prePuller and nothing else.