CI: publish with helpful commit message #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors jupyterhub/binderhub setup. The value from this message is that whenever a PR is merged, chartpress will publish a new dev version with a git push to jupyterhub/helm-chart's gh-pages branch along with the package helm chart. Since this is done with a commit message referencing the PR, GitHub will show a notice of the commit mentioning the PR when viewing the PR. And, this commit will in its title have information about the Helm chart version, which can help anyone look at a merged PR to realize what version they need to upgrade to benefit from this.