Allow exposing extra ports in autohttps/traefik deployment #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to jupyterhub#1852. Useful to explicitly expose ports in deployment too - otherwise you can't use port names like `ssh` in service definitions. To allow ingress on a port named `ssh` in traefik right now, you have to know it is listening on port 8022, and set the following: ```yaml proxy: autohttps: networkPolicy: allowedIngress: [http, https, 8022] ``` This requires knowledge that `8022` is the ssh port. Instead, it would be nice to specify `ssh` instead - and that requires defining that in the deployment. This is true for other places too - like the service definition.
consideRatio
reviewed
Nov 7, 2020
|
Nice! There is no publishing CI atm though as travis is down for us. |
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1852. Useful to explicitly expose ports
in deployment too - otherwise you can't use port names like
sshin service definitions. To allow ingress on a port namedsshin traefik right now, you have to know it is listeningon port 8022, and set the following:
This requires knowledge that
8022is the ssh port. Instead,it would be nice to specify
sshinstead - and that requiresdefining that in the deployment. This is true for other places
too - like the service definition.