Remove unused nameField helper in _helpers.tpl #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/cleanup-helpers.tpl
branch
from
d933f3b
to
05052a8
Compare
consideRatio
changed the title
consideRatio
changed the title
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 16, 2021
jupyterhub/zero-to-jupyterhub-k8s#1991 Merge pull request #1991 from consideRatio/pr/cleanup-helpers.tpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper was never adopted, and with #1923 coming in, it will be pointless.