Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Helm 3 to allow for enhancements #1994

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jan 16, 2021

Helm 2 reached end of life in November 2020, so for future releases of
this Helm chart, just like many other Helm charts have opted to do, we
drop support for Helm 2 and allow ourselves to depend on Helm 3. By
updating this Chart.yaml to apiVersion 2 we will require Helm 3.

By relying on Helm 3.1+, we can solve some long standing issues, for
example the need to manually specify proxy.secretToken.

@consideRatio consideRatio changed the title Update Chart.yaml to apiVersion 2 (requires Helm 3) Update Chart.yaml to apiVersion 2 (requires Helm 3), and require k8s 1.16. Jan 18, 2021
Helm 2 reached end of life in November 2020, so for future releases of
this Helm chart, just like many other Helm charts have opted to do, we
drop support for Helm 2 and allow ourselves to depend on Helm 3. By
updating this Chart.yaml to apiVersion 2 we will require Helm 3.

By relying on Helm 3.1+, we can solve some long standing issues, for
example the need to manually specify proxy.secretToken.
@consideRatio consideRatio changed the title Update Chart.yaml to apiVersion 2 (requires Helm 3), and require k8s 1.16. breaking: Require Helm 3 and k8s 1.17 to allow for enhancements and removal of outdated logic Jan 20, 2021
@consideRatio consideRatio changed the title breaking: Require Helm 3 and k8s 1.17 to allow for enhancements and removal of outdated logic Require Helm 3 and k8s 1.17 to allow for enhancements and removal of outdated logic Jan 20, 2021
@consideRatio consideRatio changed the title Require Helm 3 and k8s 1.17 to allow for enhancements and removal of outdated logic Require Helm 3 and k8s 1.17+ to allow for enhancements and removal of outdated logic Jan 20, 2021
@manics
Copy link
Member

manics commented Jan 21, 2021

I haven't checked the yaml changes in Chart.yaml, but I support dropping Helm 2 and K8s 1.16.

@minrk
Copy link
Member

minrk commented Jan 21, 2021

I definitely support dropping helm 2. +/- 0 on k8s 1.16 since it may cause us a headache on the mybinder.org ovh cluster. That's already out of commission, though, and has been since November due to Docker rate limit and bugs on the OVH side that make it impossible to work around. Requiring a version upgrade to stay in the federation is not unreasonable, I think.

@yuvipanda
Copy link
Collaborator

1.16 is still the 'stable' version listed on GKE - https://cloud.google.com/kubernetes-engine/docs/release-notes. I think we shouldn't drop support for it until 1.17 is the stable version.

Definitely stop helm 2 support though.

@consideRatio
Copy link
Member Author

consideRatio commented Jan 21, 2021

I think we shouldn't drop support for it until 1.17 is the stable version.

The stable channel includes k8s 1.15 to k8s 1.17 where k8s 1.17 was introduced 8th Jan. I felt that it was important to wait for it to be available in the stable channel, but not to wait for it to be the default or a version that everyone automatically would get upgraded to.

I think it's likely they will bump to k8s 1.17 as the new default in GKE stable next week based on a basic manual extrapolation. I'll go ahead and wait!

@consideRatio consideRatio changed the title Require Helm 3 and k8s 1.17+ to allow for enhancements and removal of outdated logic Require Helm 3 to allow for enhancements Jan 21, 2021
@consideRatio
Copy link
Member Author

I transformed the PR to not bump k8s requirements. Merge?

@consideRatio consideRatio merged commit ee95328 into jupyterhub:master Jan 21, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 21, 2021
jupyterhub/zero-to-jupyterhub-k8s#1994 Merge pull request #1994 from consideRatio/pr/chart-apiversion2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants