hub image build: fix use of PIP_OVERRIDES arg #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @remche!! ❤️ 🎉 Can you cleanup the three initial no-change commits also? |
consideRatio
changed the title
remche
force-pushed
the
fix-hub_pip_overrides
branch
from
9115bae
to
ce40d36
Compare
|
Congrats on your first merged pull request in this project! 🎉 |
|
🥳🥳🥳 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 16, 2021
jupyterhub/zero-to-jupyterhub-k8s#2036 Merge pull request #2036 from remche/fix-hub_pip_overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default shell for Docker build is
sh, the double bracket is not supported and pip overrides wont work.https://github.com/jupyterhub/zero-to-jupyterhub-k8s/runs/1804962086?check_suite_focus=true#step:8:1181
I used the
testnotation as few lines below.