Support setting resources to null to omit them #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/avoid-always-setting-resources
branch
from
e9c5a7f
to
c951062
Compare
|
w00p, thanks @consideRatio! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 20, 2021
jupyterhub/zero-to-jupyterhub-k8s#2055 Merge pull request #2055 from consideRatio/pr/avoid-always-setting-resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't possible to reset the resource requests such as
hub.resourcestonullbecause of our helm template logic assumed an object. This PR makes it so that if a .resources chart config value isnullor{}, then the resources section will be omitted.