Add ingress.pathType config #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
jtrouth
changed the title
consideRatio
changed the title
consideRatio
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Thanks @jtrouth and congrats on your first code contribution to this repo! ❤️ 🎉
|
Congrats on your first merged pull request in this project! 🎉 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jul 6, 2021
jupyterhub/zero-to-jupyterhub-k8s#2305 Merge pull request #2305 from jtrouth/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set the pathType field on ingress rules for situations where Prefix is not available or appropriate, such as on GKE 1.19+ with the native ingress controller which only accepts 'ImplementationSpecific' as the pathType.