Fix notebook notebook tour

jupyterlab-contrib · Aug 15, 2023 · e5b86f3 · e5b86f3
1 parent 71e7f9b
commit e5b86f3
Show file tree

Hide file tree

Showing 2 changed files with 10,838 additions and 7,756 deletions.
diff --git a/ui-tests/tests/notebook-tour.spec.ts b/ui-tests/tests/notebook-tour.spec.ts
@@ -26,17 +26,21 @@ test('should run the welcome tour', async ({ page }) => {
 test('should run the notebook tour', async ({ page }) => {
   await page.getByRole('menuitem', { name: 'File' }).click();
   await page.getByLabel('file browser').getByText('New').click();
-  await page.getByText('Notebook', { exact: true }).click();
-  await page.getByRole('button', { name: 'Select Kernel' }).click();
-  await page.getByRole('button', { name: 'Start now' }).click();
-  await page.getByLabel('Next', { exact: true }).click();
-  await page.getByLabel('Next', { exact: true }).click();
-  await page.getByLabel('Next', { exact: true }).click();
-  await page.getByLabel('Next', { exact: true }).click();
-  await page.getByLabel('Next', { exact: true }).click();
-  await page.getByLabel('Next', { exact: true }).click();
+
+  const [notebookPage] = await Promise.all([
+    page.waitForEvent('popup'),
+    page.getByText('Notebook', { exact: true }).click()
+  ]);
+  await notebookPage.getByRole('button', { name: 'Select Kernel' }).click();
+  await notebookPage.getByRole('button', { name: 'Start now' }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
+  await notebookPage.getByLabel('Next', { exact: true }).click();
   await expect
-    .soft(page.locator('.react-joyride__tooltip p'))
+    .soft(notebookPage.locator('.react-joyride__tooltip p'))
     .toHaveText(/Its name and its status are displayed here\.$/);
-  await page.getByLabel('Done').click();
+  await notebookPage.getByLabel('Done').click();
 });