Fix selectors

jupyterlab-contrib · Jul 30, 2023 · f071e01 · f071e01
1 parent 9c3cc9c
commit f071e01
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -134,7 +134,7 @@ jobs:
     - name: Execute integration tests
       working-directory: ui-tests
       run: |
-        jlpm playwright test
+        jlpm playwright test --output test-results-${{ matrix.jupyterlab }}
 
     - name: Upload Playwright Test report
       if: always()

diff --git a/pyproject.toml b/pyproject.toml
@@ -10,6 +10,7 @@ requires-python = ">=3.8"
 classifiers = [
     "Framework :: Jupyter",
     "Framework :: Jupyter :: JupyterLab",
+    "Framework :: Jupyter :: JupyterLab :: 3",
     "Framework :: Jupyter :: JupyterLab :: 4",
     "Framework :: Jupyter :: JupyterLab :: Extensions",
     "Framework :: Jupyter :: JupyterLab :: Extensions :: Prebuilt",

diff --git a/ui-tests/tests/jupyterlab-tour.spec.ts b/ui-tests/tests/jupyterlab-tour.spec.ts
@@ -20,8 +20,11 @@ test('should run the notebook tour', async ({ page }) => {
   await page.getByRole('menuitem', { name: 'File' }).click();
   await page.getByText('New', { exact: true }).click();
   await page.locator('#jp-mainmenu-file-new').getByText('Notebook').click();
-  await page.getByRole('button', { name: 'Select Kernel' }).click();
-  await page.getByRole('button', { name: 'Start now' }).click();
+  const kernelSelector = page.getByRole('button', { name: 'Select Kernel' });
+  if ((await kernelSelector.count()) > 0) {
+    await kernelSelector.click();
+  }
+  await page.getByRole('button', { name: 'Start now' }).first().click();
   await page.getByLabel('Next', { exact: true }).click();
   await page.getByLabel('Next', { exact: true }).click();
   await page.getByLabel('Next', { exact: true }).click();