Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing server settings when creating the ConfigSection #85

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 28, 2024

This should help with #82 and jupyterlite/jupyterlite#1329 (comment)

Copy link

Binder 👈 Launch a Binder on branch jtpio/jupyterlab-tour/server-settings

@jtpio jtpio added the bug Something isn't working label Feb 28, 2024
@jtpio
Copy link
Member Author

jtpio commented Feb 28, 2024

Notebook test failure might be related to the new 7.1.0 release:

23e896c7a3cccd53b84837f70b276f1abc49f98e.webm

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

The code looks good

Let's see if the fix for notebook works

@fcollonval fcollonval merged commit 3b3901e into jupyterlab-contrib:main Feb 29, 2024
7 of 8 checks passed
@jtpio jtpio deleted the server-settings branch February 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants