Fix for #8 (#9)

* produce source maps for debugging

* loading bug fixed

* reset local changes in examples

* Lint the code

---------

Co-authored-by: AnotherCodeArtist <peter.salhofer@fh-joanneumat>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>

app/webpack.config.js

@@ -177,8 +177,10 @@ module.exports = [
         type: 'var',
         name: ['_JUPYTERLAB', 'CORE_OUTPUT']
       },
-      filename: 'bundle.js'
+      filename: 'bundle.js',
+      sourceMapFilename: '[name].js.map'
     },
+    devtool: 'source-map',
     plugins: [
       new ModuleFederationPlugin({
         library: {

app/webpack.config.watch.js

@@ -1,17 +1,12 @@
 const base = require('./webpack.config');
-const ExtraWatchWebpackPlugin = require('extra-watch-webpack-plugin');
+//const ExtraWatchWebpackPlugin = require('extra-watch-webpack-plugin');
 
 module.exports = [
   {
     ...base[0],
     bail: false,
     watch: true,
-    plugins: [
-      ...base[0].plugins,
-      new ExtraWatchWebpackPlugin({
-        files: ['../packages/application/tsconfig.tsbuildinfo']
-      })
-    ]
+    plugins: [...base[0].plugins]
   },
   ...base.slice(1)
 ];

packages/application/src/plugins/rise.ts

@@ -78,7 +78,6 @@ export const plugin: JupyterFrontEndPlugin<void> = {
       app.started,
       app.restored
     ]).then(async ([settings]) => {
-      let rendered: boolean | null = null;
       const notebookPath = PageConfig.getOption('notebookPath');
       const notebookPanel = documentManager.open(notebookPath) as NotebookPanel;
 
@@ -112,11 +111,9 @@ export const plugin: JupyterFrontEndPlugin<void> = {
           change.name === 'dirty' &&
           change.newValue === false &&
           // if rendered = null || true
-          !!rendered
+          !!change.oldValue
         ) {
           console.log(`Convert notebook ${notebookPath} to slideshow.`);
-          notebookPanel.content.fullyRendered.disconnect(setRendered, this);
-          notebookPanel.model?.stateChanged.disconnect(initializeReveal, this);
 
           // Set the active cell index
           notebookPanel.content.activeCellIndex = activeCellIndex;
@@ -134,21 +131,14 @@ export const plugin: JupyterFrontEndPlugin<void> = {
         }
       };
 
-      const setRendered = (notebook: Notebook, fullyRendered: boolean) => {
-        rendered = fullyRendered;
-        if (rendered) {
-          initializeReveal(null, {
-            name: 'dirty',
-            newValue: notebook.model?.dirty ?? true,
-            oldValue: true
-          });
-        }
-      };
-
-      // Deal with virtual rendering
-      notebookPanel.content.fullyRendered.connect(setRendered, this);
-
-      notebookPanel.model?.stateChanged.connect(initializeReveal, this);
+      // Wait until the context is fully loaded
+      notebookPanel.context.ready.then(() =>
+        initializeReveal(null, {
+          name: 'dirty',
+          newValue: notebookPanel.model?.dirty ?? true,
+          oldValue: true
+        })
+      );
 
       // Remove the toolbar - fail due to the dynamic load of the toolbar items
       // notebookPanel.toolbar.dispose();

packages/application/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
-    "rootDir": "src"
+    "rootDir": "src",
+    "sourceMap": true
   },
   "include": ["src/**/*"]
 }

packages/lab/package.json

@@ -39,7 +39,7 @@
     "clean:lib": "rimraf lib tsconfig.tsbuildinfo",
     "watch": "run-p watch:src watch:labextension",
     "watch:labextension": "jupyter labextension watch .",
-    "watch:src": "tsc -w"
+    "watch:src": "tsc -w -d"
   },
   "dependencies": {
     "@jupyterlab/application": "^3.2.0",

packages/lab/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
-    "rootDir": "src"
+    "rootDir": "src",
+    "sourceMap": true
   },
   "include": ["src/*"]
 }

tsconfigbase.json

@@ -18,7 +18,8 @@
     "strict": true,
     "strictNullChecks": true,
     "target": "es2017",
-    "types": ["jest"]
+    "types": ["jest"],
+    "sourceMap": true
   },
   "include": ["src/*"]
 }