Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the shortcut triggered in edit mode #61

Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Dec 6, 2023

This PR fixes #33 by changing the command selectors to the notebook in command mode.

It supersedes #58.

It also ensure the focus to the notebook node, to ensure the command are triggered when focusing the rise panel.

Copy link

github-actions bot commented Dec 6, 2023

Binder 👈 Launch a Binder on branch brichet/rise/fix-shortcut-commandMode

@brichet brichet added the bug Something isn't working label Dec 8, 2023
@brichet brichet self-assigned this Dec 8, 2023
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou martinRenou merged commit d082264 into jupyterlab-contrib:main Dec 8, 2023
6 of 7 checks passed
@brichet brichet deleted the fix-shortcut-commandMode branch December 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cells editing has strange behaviour when pressing keys
2 participants