-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to JupyterLab 4.0/CodeMirror6 #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127:
@jupyterlab-contrib/spellchecker
for consistencyA big step towards #39:
text/x-ipython
andtext/x-rsrc
correspondingly, or by disabling "check spelling in comments").Previous implementation used a custom mode overlaid on top of the active highlighting mode, which repeatedly executed regular expressions on the incoming stream. This meant no awareness of syntax which required masking out undesired tokens post-hoc by combining CSS selectors of tokens and prevented checking only selected fragments of code, e.g. comments and strings.
This PR uses alternative approach of masking out syntax tokens with whitespaces and splitting into words with a single ES2020
re.matchAll
call, followed by decorating the syntax errors using the linter plugin (which is super fast and also enables us to easily display gutter and a panel of errors - if we want to add it later).Parsing and checking 150 paragraphs, 13 227 words (lorem ipsum) takes 21 milliseconds on Chromium. It is difficult to measure equivalent performance with the old version, but it seems broadly comparable, with much potential to improve if we move spellchecking to a webworker in the future.
New class name is used for tokens:
cm-lintRange-spell
.