Do not redefine refreshCompleterState on each render (#875)

jupyterlab · Jul 8, 2024 · 43a0e8f · 43a0e8f
1 parent 9e1b4fd
commit 43a0e8f
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/packages/jupyter-ai/src/components/chat-settings.tsx b/packages/jupyter-ai/src/components/chat-settings.tsx
@@ -93,13 +93,12 @@ export function ChatSettings(props: ChatSettingsProps): JSX.Element {
     props.completionProvider && props.completionProvider.isEnabled()
   );
 
-  const refreshCompleterState = () => {
-    setIsCompleterEnabled(
-      props.completionProvider && props.completionProvider.isEnabled()
-    );
-  };
-
   useEffect(() => {
+    const refreshCompleterState = () => {
+      setIsCompleterEnabled(
+        props.completionProvider && props.completionProvider.isEnabled()
+      );
+    };
     props.completionProvider?.settingsChanged.connect(refreshCompleterState);
     return () => {
       props.completionProvider?.settingsChanged.disconnect(