Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds help text for registry model providers in chat UI settings #373

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Aug 29, 2023

Fixes #260. If the user selects a model provider that is a registry, with '*' listed as its only model, displays the help text in the settings panel, interpreted as markdown. Links are displayed in browser default styles, not as uncolored, undecorated text as a tags usually are in JupyterLab, and they open in a new window/tab.

Minor modification to the Hugging Face help so that its URL always displays as a link. Minor edits to SageMaker endpoints help so that it makes sense both here and in %ai list.

Screenshot 2023-08-29 at 4 37 39 PM Screenshot 2023-08-29 at 4 23 25 PM

@JasonWeill JasonWeill added enhancement New feature or request @jupyter-ai/chatui labels Aug 29, 2023
@dlqqq
Copy link
Member

dlqqq commented Sep 5, 2023

We discussed this PR within our team. Currently, we're looking to move away from react-markdown, so we would like to re-work this PR to use a less heavy-handed dependency to implement the help string. Furthermore, this also introduces merge conflicts with #353, so it would be best to hold this PR off until the next release. 👍

packages/jupyter-ai/src/components/chat-settings.tsx Outdated Show resolved Hide resolved
packages/jupyter-ai/src/components/chat-settings.tsx Outdated Show resolved Hide resolved
packages/jupyter-ai/src/components/chat-settings.tsx Outdated Show resolved Hide resolved
packages/jupyter-ai/style/chat-settings.css Show resolved Hide resolved
@dlqqq dlqqq mentioned this pull request Sep 7, 2023
@JasonWeill JasonWeill merged commit 640f36c into jupyterlab:main Sep 7, 2023
5 checks passed
JasonWeill added a commit that referenced this pull request Sep 7, 2023
* WIP change: display help in settings panel

* Interprets markdown, updates Hugging Face help with explicit link

* Edits SageMaker help to be neutral in use

* Displays help message for all providers with one
JasonWeill added a commit that referenced this pull request Sep 7, 2023
JasonWeill added a commit to JasonWeill/jupyter-ai that referenced this pull request Sep 7, 2023
…terlab#373)

* WIP change: display help in settings panel

* Interprets markdown, updates Hugging Face help with explicit link

* Edits SageMaker help to be neutral in use

* Displays help message for all providers with one
JasonWeill added a commit that referenced this pull request Sep 7, 2023
#383)

* WIP change: display help in settings panel

* Interprets markdown, updates Hugging Face help with explicit link

* Edits SageMaker help to be neutral in use

* Displays help message for all providers with one
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
…terlab#373)

* WIP change: display help in settings panel

* Interprets markdown, updates Hugging Face help with explicit link

* Edits SageMaker help to be neutral in use

* Displays help message for all providers with one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @jupyter-ai/chatui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve help in chat UI settings panel for Hugging Face Hub, SageMaker endpoints
2 participants