Chat backend #40
Merged
Chat backend #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
requested changes
Apr 7, 2023
There was a problem hiding this comment.
@3coins This looks great! See the comments I left. Also, you should exclude all frontend changes with the exception of src/chat_handler.ts to minimize merge conflicts. The easiest way to do this would be to run:
git checkout main -- <path-to-file>
For each file that doesn't exist on main, you will get an error like so:
% git checkout main -- packages/jupyter-ai/src/components/chat.tsx
error: pathspec 'packages/jupyter-ai/src/components/chat.tsx' did not match any file(s) known to git
In which case, you should just run git rm <path-to-file>.
|
Congrats on your first merged pull request in this project! 🎉 |
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* implement chat UI * WIP: Chat backend * Working version with reply * Working chat backend with websocket * Fixed error * Added types for messages * Aligned with main branch, removed chat UI components. * Removed yarn.lock updates --------- Co-authored-by: David L. Qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR incudes the changes for the backend API for the chat feature. There are two main components.
API Details
Consumes and broadcasts messages
Returns message history
Clears the chat history