Remove stale @jupyterlab/collaboration dependency
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed on first commit due to stricter type checks after cutting out old versions: I also saw this in the inline completions PR. This was addressed by 073c2b1. |
krassowski
force-pushed
the
remove-old-collaboration-package
branch
from
50207d0
to
39a5ecd
Compare
krassowski
force-pushed
the
remove-old-collaboration-package
branch
from
39a5ecd
to
073c2b1
Compare
dlqqq
approved these changes
Nov 25, 2023
|
Note to other contributors: do not backport this PR. |
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Remove stale `@jupyterlab/collaboration` dependency * Set explicit type for `emsg`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480
This is the best feeling kind of a PR:
13 additions and 688 deletions.Should also make the source installations smaller and CI faster/better dev experience.