Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make selections more robust #54

Merged
merged 1 commit into from
Apr 12, 2023
Merged

make selections more robust #54

merged 1 commit into from
Apr 12, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Apr 12, 2023

Description

Makes the selection experience significantly more robust by changing the implementation of SelectionWatcher:

  • selection ranges and their text are stored into a new Selection object, which means users can change their selection after submitting a request via the Chat UI
  • widget IDs are also tracked, previous widget will be activated upon selection replacement
  • cell IDs are also tracked for notebooks, cell will be activated upon selection replacement

Demo

Screen.Recording.2023-04-11.at.6.31.37.PM.mov

@dlqqq dlqqq added the enhancement New feature or request label Apr 12, 2023
@dlqqq dlqqq merged commit b828199 into jupyterlab:main Apr 12, 2023
@dlqqq dlqqq deleted the robust-selection branch April 12, 2023 02:03
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@dlqqq
make selection more robust (jupyterlab#54)
5488763
@brichet brichet mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlqqq