Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement better chat history UI #65

Merged
merged 3 commits into from
Apr 14, 2023
Merged

implement better chat history UI #65

merged 3 commits into from
Apr 14, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Apr 14, 2023 •
edited
Loading

Description

Implements a new design for chat history that elegantly supports RTC.

  • Retrieves user avatars from global awareness from @jupyterlab/collaboration
  • Backend generates a UNIX timestamp for each message
  • Chat history refreshes timestamp every 5 seconds
  • Implements basic scroll pinning: leverages an overflow-anchor CSS hack to lock viewport to bottom of scroll container if the viewport is already at the bottom of the scroll container.

Demo

Screen.Recording.2023-04-13.at.10.58.35.PM.mov

Next steps

@dlqqq dlqqq added the enhancement New feature or request label Apr 14, 2023
@dlqqq dlqqq marked this pull request as ready for review April 14, 2023 06:02
@dlqqq dlqqq merged commit 126d841 into jupyterlab:main Apr 14, 2023
@dlqqq dlqqq deleted the better-chat-ui branch April 14, 2023 14:52
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@dlqqq
implement better chat history UI (jupyterlab#65)
a4cdde7 
* implement better chat history UI

* remove console log

* add ScrollContainer component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlqqq