Improve support for custom providers #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds 3 new provider class attributes: 1. `manages_history` 2. `unsupported_slash_commands` 3. `persona`
krassowski
reviewed
Apr 3, 2024
dlqqq
force-pushed
the
better-custom-providers
branch
from
7d68955
to
568adcf
Compare
3coins
approved these changes
Apr 4, 2024
|
@meeseeksdev please backport to 1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
dlqqq
added a commit
that referenced
this pull request
Apr 4, 2024
…#715) * improve support for custom providers adds 3 new provider class attributes: 1. `manages_history` 2. `unsupported_slash_commands` 3. `persona` * pre-commit * add comment about jupyternaut icon in frontend * remove 'avatar_path' from 'Persona', drop 'PersonaDescription' * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom providers may lack capabilities that are supported in other providers. Furthermore, some developers writing custom providers want to specify a persona, a custom name and avatar shown on agent replies in the chat UI.
This PR adds 3 new attributes to
BaseProvider:manages_history(default:False): Whether this provider manages its own chat history upstream. This should be set toTrueif the provider service somehow persists its own chat history without the need for Jupyter AI to pass chat history as part of the prompt.unsupported_slash_commands(default: empty set): A set of slash commands unsupported by this provider. Unsupported slash commands are not shown in the help message and are not available for use while this provider is selected. For example, if a provider does not support RAG, this should be set to{/learn, /ask}.persona(default:None): A structure that contains a name and avatar that is shown on agent replies in the chat UI. When set toNone(default), Jupyter AI will choose a persona, which currently defaults toJupyternautPersona. Otherwise, the persona set on this field takes precedence.